Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding my art to the project #2577

Closed
wants to merge 1 commit into from

Conversation

BravoKolos
Copy link

Hey! Please add me to the list :)

Copy link

🙏 Thanks for your pull request @BravoKolos, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2577 50 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 319 3410

@LaurelineP
Copy link
Contributor

Aloha @BravoKolos 🙌
Thanks for your contribution and time !
Before we could merge your contribution, the following feedbacks need to be addressed first.
Please address the given feedbacks

Note

Checked values - are the one that are correctly done

  • Please address all the unchecked elements
  • If you need guidance , please refer to the

Tip

If the name of your folder needs to be changed ensure to adjust the include.js

Feedbacks:

  • the folder should have the same name as your github user name
  • please update your local branch as I will resolve some conflicts you may have in include.js
  • missing pictural representation of your animation
  • in include.js please remove the chevrons wrapping your github user name

🔹 Reference Acceptance criteria for a contribution

Correctly:

  • Folder name: named after the github user name in ./Art
    • contains a HTML file: the contribution must have an HTML file
      • has a tag to the CSS file of the project
      • contains the HTML content for the animation
      • does not contain a SVG replacing the whole HTML CSS animation requirements
    • contains a CSS file: the contribution must have a CSS file
    • does not contain a JS file or JS logic : No JS logic should be part of your submission
    • the contribution includes the animated file (gif) or picture ( jpeg, jpg, png )
    • the pictural representation must not include the browser frame, just the animation
    • the contribution includes the correct contribution's details in include.js
      • the relative path should be correct : referring to the correct named folder
      • author: the value should be the github name or github
      • artName: the value should be the animation title
      • pageLink: the value should be the relative path to your project's HTML file
      • imageLink: should refer to the project relative path's image
      • githubLink: the value should be your github profile link
      • does not have chevrons
      • does not have comments for each fields

@zero-to-mastery-bot zero-to-mastery-bot bot added the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Aug 12, 2024
Copy link

⚠️ MERGE CONFLICT DETECTED!

@BravoKolos A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

2 similar comments
Copy link

⚠️ MERGE CONFLICT DETECTED!

@BravoKolos A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

Copy link

⚠️ MERGE CONFLICT DETECTED!

@BravoKolos A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@MattCSmith MattCSmith closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants